Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Moved validation styling to component scope. #172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Moved validation styling to component scope. #172

wants to merge 1 commit into from

Conversation

Igor-Vladyka
Copy link

Fixes #140 and maybe a few others.

General problem:

Due to internal dirty check of polymer notification logic that prevents notification of computed methods with more than one argument in case when changed value from 'any' to undefined;

Fix steps:

  • Removed validation class setup from the checkbox div (now computed property will hold only one argument).
  • Changed validation styling to rely on iron-validatable-behavior in the first place.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@Igor-Vladyka
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants